Skip to content

Conversation

@DrPaulSharp
Copy link
Collaborator

No description provided.

@DrPaulSharp DrPaulSharp requested a review from StephenNneji June 19, 2024 14:37
RAT.utils.plotting.plot_ref_sld(project, results)

# C++
project.custom_files.set_fields(0, filename='custom_bilayer.dll', language='cpp')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I change the filename to customBilayer.dll the function does not update it is still custom_bilayer

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll need to recompile. I'll add the README.md from the matlab which contains the compilation instructions.

Copy link
Contributor

@StephenNneji StephenNneji Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compilation instructions are in the docs, no need to copy them over. What I am taking about is on the Matlab side if I do
problem.addCustomFile('DSPC Model','customBilayer.m','matlab',pwd);
The function is set to customBilayer but then if I do
problem.setCustomFile(1,'filename', 'custom_bilayer.py', 'path', path);
the function is set to 'custom_bilayer' unless I explicitly specified a function name

On the python side, the function stays the same after the filename is changed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I've set it up to have the function name mapped to the filename for matlab, and free otherwise. Let me know what you think of this behaviour.

Copy link
Contributor

@StephenNneji StephenNneji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job, Thanks for your hard work on this one amidst the confusion.

Copy link
Contributor

@StephenNneji StephenNneji Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an __init__.py file to this folder also, otherwise it won't be copied when the user installs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the "tests/test_data" directory need one as well then?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed, at the moment, we don't copy tests for install

@DrPaulSharp DrPaulSharp merged commit cafba0e into RascalSoftware:main Jun 25, 2024
@DrPaulSharp DrPaulSharp deleted the examples branch June 25, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants